Expose the legacy guest/non-guest flag on users in the admin API #5014
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
sandhose
commented
Sep 15, 2025
sandhose
commented
- Surface the user guest flag in the admin API
- Allow filtering guest/non-guest users
Deploying matrix-authentication-service-docs with
|
| Latest commit: |
1e1dfda
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://b576ba81.matrix-authentication-service-docs.pages.dev |
| Branch Preview URL: | https://quenting-admin-api-user-gues.matrix-authentication-service-docs.pages.dev |
sandhose
force-pushed
the
quenting/admin-api/user-guest
branch
from
bd84504 to
58e075b
Compare
sandhose
added
A-Admin-API
reivilibre
approved these changes
Sep 15, 2025
| .add_option(self.can_request_admin().map(|can_request_admin| { | ||
| Expr::col((Users::Table, Users::CanRequestAdmin)).eq(can_request_admin) | ||
| })) | ||
| .add_option( |
There was a problem hiding this comment.
is the index on (is_guest, can_request_admin) intended to be a future PR?
There was a problem hiding this comment.
Yes, but also low-priority for now, it is performant enough in most cases
sandhose
force-pushed
the
quenting/admin-api/user-guest
branch
from
58e075b to
c774648
Compare
sandhose
force-pushed
the
quenting/admin-api/user-guest
branch
from
c774648 to
278d2af
Compare
sandhose
force-pushed
the
quenting/admin-api/user-guest
branch
from
278d2af to
1e1dfda
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.